Fix various valgrind reported uninitialized variable uses

2018-02-28 21:55:13 +01:00
parent c6dff58f49
commit d702d7b335
8 changed files with 20 additions and 7 deletions
@@ -1193,6 +1193,7 @@ bool OS_X11::is_window_maximized() const {
 	unsigned long len;
 	unsigned long remaining;
 	unsigned char *data = NULL;
+	bool retval = false;

 	int result = XGetWindowProperty(
 			x11_display,
@@ -1221,13 +1222,15 @@ bool OS_X11::is_window_maximized() const {
 			if (atoms[i] == wm_max_vert)
 				found_wm_max_vert = true;

-			if (found_wm_max_horz && found_wm_max_vert)
-				return true;
+			if (found_wm_max_horz && found_wm_max_vert) {
+				retval = true;
+				break;
+			}
 		}
-		XFree(atoms);
 	}

-	return false;
+	XFree(data);
+	return retval;
 }

 void OS_X11::set_window_always_on_top(bool p_enabled) {