noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Do not emit NOTIFICATION_READY more than once (breaking change)

Browse Source 
Currently, there is no notification with the old behaviour, so probably breaks all cpp code relying on that notification as well.
This commit is contained in:
Bojidar Marinov
2016-11-17 18:46:45 +02:00
parent 184173a9b9
commit b6eab006db
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scene/main/node.cpp
View File

@@ -166,14 +166,16 @@ void Node::_notification(int p_notification) {
void Node::_propagate_ready() {
data.ready_notified=true;
data.blocked++;
for (int i=0;i<data.children.size();i++) {
data.children[i]->_propagate_ready();
}
data.blocked--;
notification(NOTIFICATION_READY);
if(!data.ready_notified) {
data.ready_notified=true;
notification(NOTIFICATION_READY);
}
}
@@ -2663,9 +2665,7 @@ void Node::_set_tree(SceneTree *p_tree) {
_propagate_enter_tree();
if (!data.parent || data.parent->data.ready_notified) { // No parent (root) or parent ready
_propagate_ready(); //reverse_notification(NOTIFICATION_READY);
}
_propagate_ready(); //reverse_notification(NOTIFICATION_READY);
tree_changed_b=data.tree;