noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #81354 from MJacred/textedit_pixel_pos_fix

Browse Source 
Fix `TextEdit.get_rect_at_line_column returning` negative pos even though cursor is in viewable area of the control
This commit is contained in:
Rémi Verschelde
2023-09-18 10:37:59 +02:00
parent 3e233e1f24 6170381bd7
commit 77623d0a36
2 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scene/gui/text_edit.cpp
+7 -1
View File
@@ -1298,7 +1298,8 @@ void TextEdit::_notification(int p_what) {
if (had_glyphs_drawn) {
if (first_visible_char > glyphs[j].start) {
first_visible_char = glyphs[j].start;
} else if (last_visible_char < glyphs[j].end) {
}
if (last_visible_char < glyphs[j].end) {
last_visible_char = glyphs[j].end;
}
}
@@ -4328,6 +4329,11 @@ Rect2i TextEdit::get_rect_at_line_column(int p_line, int p_column) const {
ERR_FAIL_COND_V(p_column < 0, Rect2i(-1, -1, 0, 0));
ERR_FAIL_COND_V(p_column > text[p_line].length(), Rect2i(-1, -1, 0, 0));
if (text.size() == 1 && text[0].length() == 0) {
// The TextEdit is empty.
return Rect2i();
}
if (line_drawing_cache.size() == 0 || !line_drawing_cache.has(p_line)) {
// Line is not in the cache, which means it's outside of the viewing area.
return Rect2i(-1, -1, 0, 0);