noahbackus/godot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 2 Wiki Activity

Merge pull request #21411 from Crazy-P/fixes-several-resource-leaks

Browse Source 
Fixes several resource leaks listed on coverity
This commit is contained in:
Rémi Verschelde
2018-08-26 17:35:32 +02:00
committed by GitHub
parent 653b4829f1 e4af39cbc0
commit 282c0483c9
6 changed files with 48 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
drivers/gles3/rasterizer_scene_gles3.cpp
+4 -1
View File
@@ -1008,7 +1008,10 @@ RID RasterizerSceneGLES3::light_instance_create(RID p_light) {
light_instance->light = p_light;
light_instance->light_ptr = storage->light_owner.getornull(p_light);
ERR_FAIL_COND_V(!light_instance->light_ptr, RID());
if (!light_instance->light_ptr) {
memdelete(light_instance);
ERR_FAIL_COND_V(!light_instance->light_ptr, RID());
}
light_instance->self = light_instance_owner.make_rid(light_instance);
drivers/gles3/rasterizer_storage_gles3.cpp
+4 -1
View File
@@ -6998,7 +6998,10 @@ RID RasterizerStorageGLES3::canvas_light_shadow_buffer_create(int p_width) {
//printf("errnum: %x\n",status);
glBindFramebuffer(GL_FRAMEBUFFER, RasterizerStorageGLES3::system_fbo);
ERR_FAIL_COND_V(status != GL_FRAMEBUFFER_COMPLETE, RID());
if (status != GL_FRAMEBUFFER_COMPLETE) {
memdelete(cls);
ERR_FAIL_COND_V(status != GL_FRAMEBUFFER_COMPLETE, RID());
}
return canvas_light_shadow_owner.make_rid(cls);
}